Hi all, following the discussion about static analysis, and considering there have been no negative statements about it, here is a branch to host the collaborative work on adding automatic QA checks in the codebase: https://github.com/geotools/geotools/tree/qa
There is also a pull request to check the status of the build: https://github.com/geotools/geotools/pull/2214 Next steps: - I want to see if I can use the Travis build matrix ability in order to have three builds, a jdk 8 without formatting checks, a jdk 11 without formatting checks, and a QA JDK 8 build that does formatting checks and PMD (and more in the future) without running the tests. If/when this gets merged (I'm hopeful!) I'd also add a separate build, one that sends hate mails on failure, on the official Jenkins. Benefit of this approach would be that the QA build would not add time to the already too long GeoTools builds on Travis, and would leverage a separate build VM instead. - Add more PMD rules (maybe let's all send a mail about what kind of rule is being added so that we don't end up working on the same one?) - Maybe explore adding ErrorProne too? About adding ErrorProne, in the previous email I've noted a bug about building on JDK11, but the system actually needs at least JDK9, for JDK 8 it offers a patched version of javac (that's what the errorprone branch referred in the previous thread uses). I guess we could keep on using that one, provided that the QA build does not "install" anything and/or uses its own separate repository. Or maybe the JDK11 issue is specific to a particular source code and we won't stumble into it Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
