Hi all, think I'm getting to a point where I'm satisfied with the results: - added a few more rules in PMD - added errorprone in the mix and got a full build going (requires JDK 11) - the travis build is still erratic, works fine locally but goes OOM on Travis (done at least twice) apparently due to PMD (happened before errorprone integration). Guessing mvn does not have enough heap but I might be wrong
The errorprone round was quite interesting, almost 100% valid and useful reports, like hashcode/equal on arrays, tests that are there but not being run, NaN comparisons and the like. Moreover, was rather quick to make work, in the end most of the issues where in the main module. More fixes, comments and reviews appreciated! Cheers Andrea On Thu, Dec 27, 2018 at 11:19 AM Andrea Aime <andrea.a...@geo-solutions.it> wrote: > On Thu, Dec 27, 2018 at 9:01 AM Andrea Aime <andrea.a...@geo-solutions.it> > wrote: > >> Next steps: >> >> - I want to see if I can use the Travis build matrix ability in order >> to have three builds, a jdk 8 without formatting checks, a jdk 11 without >> formatting checks, and a QA JDK 8 build that does formatting checks and >> PMD >> (and more in the future) without running the tests. If/when this gets >> merged (I'm hopeful!) I'd also add a separate build, one that sends hate >> mails on failure, on the official Jenkins. Benefit of this approach would >> be that the QA build would not add time to the already too long GeoTools >> builds on Travis, and would leverage a separate build VM instead. >> >> This part should be done, see this build: > https://travis-ci.org/geotools/geotools/builds/472591585?utm_source=github_status&utm_medium=notification > > >> >> - Add more PMD rules (maybe let's all send a mail about what kind of >> rule is being added so that we don't end up working on the same one?) >> >> Adding one that disallows System.out/err in code (a priority 2 rule). > There are a number of legit usages that are being kept annotating the code > with @SuppressWarnings("PMD.SystemPrintln"), > this approach can be used to disable PMD for false > positives, @SuppressWarnings("PMD.<RuleNameHere>") > > Btw, there are some rules that are not active in the custom PMD config > file because they are priority 3. > Not sure how we want to proceed here, I'd go with priority 2 first, but > avoid the ones that one finds debatable (e.g., I've skipped the "avoid > reassiging parameter" one for example, since I know there is a lot of those > cases around). > > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
