So we have the following votes: - Andrea Aime +1 - Ian Turton +1 - Jody Garnett +1 - Nuno Oliveira +1 - Simone Giannecchini - Torben Barsballe +1
It has also been more that 15 days <https://docs.geotools.org/latest/developer/procedures/proposal.html#voting> since initial proposal :) Here is PR for review: https://github.com/geotools/geotools/pull/2743 Notes: - While we can squash and merge this, I do not really see the need as it is not intended for backport. - I took special care to respect the BSD license for the 'specification" docs - Torben I noted some duplication in the documentation and wondered if you had any insight -- Jody Garnett On Thu, 6 Feb 2020 at 17:49, Ian Turton <ijtur...@gmail.com> wrote: > +1 > > Ian > > On Thu, 6 Feb 2020 at 16:43, Nuno Oliveira <nuno.olive...@geo-solutions.it> > wrote: > >> +1 >> On Wed, 2020-01-22 at 18:33 +0100, Andrea Aime wrote: >> >> +1 on the graduation >> Would love to see Torben act a co-maintainer, but not a requirement. >> >> Cheers >> Andrea >> >> On Mon, Jan 13, 2020 at 9:03 AM Jody Garnett <jody.garn...@gmail.com> >> wrote: >> >> On Sun, 12 Jan 2020 at 23:38, Andrea Aime <andrea.a...@geo-solutions.it> >> wrote: >> >> On Mon, Jan 13, 2020 at 8:22 AM Jody Garnett <jody.garn...@gmail.com> >> wrote: >> >> I would like to propose MBStyle for graduation: >> >> Gold Star Plugin QA Test >> <https://docs.geotools.org/latest/developer/procedures/check.html>: >> >> - Module maintainer: Jody Garnett (GeoCat) >> >> >> So far I asked Torben to review the PRs, should I route the PR review >> requests to you then? >> >> >> If Torben is in position to act as module maintainer also that would be >> great. >> >> >> - Used in anger: shipped as part of boundless suite >> >> >> Hum... isn't the suite dead? Did it get some exposure? >> >> >> Some. >> >> That said, many of these are now closed, with a few PRs more and it will >> more or less translate decently the osm-bright-gl OMT >> <https://github.com/openmaptiles/osm-bright-gl-style> style. The other >> OMT styles >> <https://github.com/openmaptiles?utf8=%E2%9C%93&q=gl-style&type=&language=> >> need some more work, >> if you want to play with them easily see this GeoServer data dir: >> https://github.com/geosolutions-it/openmaptiles (most of the issue now >> can be spotted by looking at the maps >> side by side with a Maputnik editor >> <https://maputnik.github.io/editor/#1/0/0>). >> >> >> Thanks, that is good to know. >> >> >> - Optimized: non-performance critical code >> - Supported: community module documentation >> >> <https://docs.geotools.org/latest/userguide/unsupported/mbstyle/index.html> >> has >> required code example, and a copy of the mapbox style specification >> indicating which aspects are implemented. I would like >> >> >> Additional: >> >> - Developers guide: code has been consistently reviewed during >> development, subject to automated formatting and Andrea's recent QA safety >> measures >> >> >> >> I am finding some issues here (just trying to run a report to see JaCoCo >> test coverage). Starting a PR here mbstyle review >> <https://github.com/geotools/geotools/pull/2743> >> >> >> - Code Coverage: Getting "Skipping JaCoCo execution due to missing >> execution data file" any tips welcome >> >> >> IntelliJ reports a 87% coverage on the module, which is pretty good. (all >> of the issues I worked on either lacked a test or were testing for non >> compliant behavior). >> >> >> Thanks, so far I have been unable to get JaCoCo to run (even though the >> plugin is configured in our root pom). Does anyone have an example I can >> add to the docs? >> >> Cheers >> Jody >> >> >> >> -- >> >> Regards, Andrea Aime == GeoServer Professional Services from the experts! >> Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime >> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 >> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 >> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it >> ------------------------------------------------------- *Con riferimento >> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - >> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni >> circostanza inerente alla presente email (il suo contenuto, gli eventuali >> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i >> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per >> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le >> sarei comunque grato se potesse darmene notizia. This email is intended >> only for the person or entity to which it is addressed and may contain >> information that is privileged, confidential or otherwise protected from >> disclosure. We remind that - as provided by European Regulation 2016/679 >> “GDPR” - copying, dissemination or use of this e-mail or the information >> herein by anyone other than the intended recipient is prohibited. If you >> have received this email by mistake, please notify us immediately by >> telephone or e-mail.* >> >> _______________________________________________ >> GeoTools-Devel mailing >> listGeoTools-Devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geotools-devel >> >> -- >> Regards, >> Nuno Oliveira >> == >> GeoServer Professional Services from the >> experts! >> Visit http://goo.gl/it488V for more information. >> == >> >> Nuno Miguel Carvalho Oliveira >> @nmcoliveira >> Software Engineer >> >> GeoSolutions S.A.S. >> Via di Montramito 3/A >> 55054 Massarosa (LU) >> Italy >> phone: +39 0584 962313 >> fax: +39 0584 1660272 >> http://www.geo-solutions.ithttp://twitter.com/geosolutions_it >> >> ------------------------------------------------------- >> >> Con riferimento alla normativa sul trattamento dei dati >> personali (Reg. UE 2016/679 - Regolamento generale sulla >> protezione dei dati “GDPR”), si precisa che ogni >> circostanza inerente alla presente email (il suo contenuto, >> gli eventuali allegati, etc.) è un dato la cui conoscenza >> è riservata al/i solo/i destinatario/i indicati dallo >> scrivente. Se il messaggio Le è giunto per errore, è >> tenuta/o a cancellarlo, ogni altra operazione è illecita. >> Le sarei comunque grato se potesse darmene notizia. >> >> This email is intended only for the person or entity to >> which it is addressed and may contain information that >> is privileged, confidential or otherwise protected from >> disclosure. We remind that - as provided by European >> Regulation 2016/679 “GDPR” - copying, dissemination or >> use of this e-mail or the information herein by anyone >> other than the intended recipient is prohibited. If you >> have received this email by mistake, please notify >> us immediately by telephone or e-mail. >> >> _______________________________________________ >> GeoTools-Devel mailing list >> GeoTools-Devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> > > > -- > Ian Turton >
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
