I've started factoring out the deprecations and seeing some test failures that don't seem related. So I'm curious if anybody ran the oracle online tests recently? and if there are known failures.

Notably:

=1=
a failing test: Oracle3DOnlineTest#testBBOX3DOutsideLine() inherited from JDBCGeneric3DOnlineTest

I see some WARNING messages in the output log about "3 dimensioned geometry provided. This encoder only supports 2D linestring geometries. The query will be constructed as a 2D query." so I'm wondering if this is expected because a 2D filter is used instead of a 3D

=2=
I see some messages "java.lang.ClassCastException: org.geotools.jdbc.JDBCFeatureSource cannot be cast to org.geotools.jdbc.JDBCFeatureStore"

when the OraclePrimaryKeyFinderOnlineTest runs (all cases fail for that test)

=3=
I'm getting a NPE on the datastore in OracleTypeNamesOnlineTest#testTypeNames() that inherits from JDBCTypeNamesOnlineTest

any hints or experiences are welcome;
(I have yet to try and see the results with master)

Mark


On 09-03-2020 14:03, Mark Prins wrote:
Created:
- https://osgeo-org.atlassian.net/browse/GEOT-6529
- https://osgeo-org.atlassian.net/browse/GEOS-9535

Will follow up on those issues with PR's ASAP

Mark


On 02-03-2020 19:12, Jody Garnett wrote:
A PR would be great, and we can include the *Oracle Free Use Terms and
Conditions (FUTC)* license in the extension if that is what is required.

Also individual extensions can make notices in the server status modules tab, if they want to report availability of a library, or link to some license notice (if that is required in the running application).
--
Jody Garnett


On Mon, 2 Mar 2020 at 02:45, Mark Prins <mc.pr...@gmail.com <mailto:mc.pr...@gmail.com>> wrote:

    On 13-12-2019 11:08, Jody Garnett wrote:
     > Following up on last meetings discussion on supporting oracle:
    Oracle
     > JDBC drivers on Maven Central
     >
<https://medium.com/oracledevs/oracle-jdbc-drivers-on-maven-central-64fcf724d8b>
     >
     > Based on the I would like to remove the manual process of installing
     > ojdbc7 into your local repo, and replace with something like:
     >
     >      <dependency>
     >       <groupId>com.oracle.ojdbc</groupId>
     >       <artifactId>ojdbc8</artifactId>
     >       <version>19.3.0.0</version>
     >      </dependency>
     >
     > Can I ask if anyone is using odjbc8 already?

    I don't think this happened yet has it?

    Oracle's first try at using Maven central was nearly succesful;
    advancing insights made them decide to move the drivers to diffent
    groupId's as described in the post om medium [1]

    the TLDR:
    - all versions now available (19.3.0.0, 18.3.0.0, 12.2.0.1 and some
    11.2.0.4)
    - new groupId for production jar's at com.oracle.database.jdbc
    - net groupId for debug jars (postfixed with _g) at
    com.oracle.database.jdbc.debug
    - all have sources + javadoc jar's as required

    so above snippet should be

          <dependency>
            <groupId>com.oracle.database.jdbc</groupId>
            <artifactId>ojdbc8</artifactId>
            <version>19.3.0.0</version>
          </dependency>

    for production use, or

          <dependency>
            <groupId>com.oracle.database.jdbc.debug</groupId>
            <artifactId>ojdbc8_g</artifactId>
            <version>19.3.0.0</version>
          </dependency>

    for debugging.

    I can prepare a PR if you like.

    Not sure where to a a note about the license "Oracle Free Use Terms and
    Conditions (FUTC)"
    (I think that would only concern geoserver as that would/could
    distribute the driver jar with the extension. Some lawyer should decide
    on that I guess.)

    [1]
https://medium.com/@kuassimensah/all-in-and-new-groupids-oracle-jdbc-drivers-on-maven-central-a76d545954c6




    _______________________________________________
    GeoTools-Devel mailing list
    GeoTools-Devel@lists.sourceforge.net
    <mailto:GeoTools-Devel@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/geotools-devel





_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to