turns out the failures in "OraclePrimaryKeyFinderOnlineTest" were caused by me having "schema=geotools" instead of "schema=GEOTOOLS" in my ~/.geotools/oracle.properties. (What was I thinking!...)
PR https://github.com/geotools/geotools/pull/2832 is now ready for review, I've disabled the Oracle3DOnlineTest>OnlineTestCase.run:112-> JDBCGeneric3DOnlineTest.testBBOX3DOutsideLine testcase; I don't think it will work / also fails on master. This leaves 435 test passing. Mark Op vr 13 mrt. 2020 om 12:38 schreef Mark Prins <mc.pr...@gmail.com>: > > Getting the exact same errors and failures when running with the master > branch, so I'm going to ignore those for now; I looked at the > testBBOX3DOutsideLine test and tried running the supposed select in my > DBeaver, giving the same result, see below. > > git checkout master && git pull upstream master > mvn clean install -Dall -T1.1C > mvn clean install -Dall -pl :gt-jdbc-oracle -Ponline -T1.1C -Doracle=true > > gives me: > > [INFO] > [INFO] Results: > [INFO] > [ERROR] Failures: > [ERROR] > Oracle3DOnlineTest>OnlineTestCase.run:112->JDBCGeneric3DOnlineTest.testBBOX3DOutsideLine:181 > expected:<0> but was:<2> > [ERROR] > OraclePrimaryKeyFinderOnlineTest>OnlineTestCase.run:112->JDBCPrimaryKeyFinderOnlineTest.testSequencedPrimaryKey:46 > [ERROR] Errors: > [ERROR] > OraclePrimaryKeyFinderOnlineTest>OnlineTestCase.run:112->JDBCPrimaryKeyFinderOnlineTest.testAssignedMultiPKeyView:68 > » ClassCast > [ERROR] > OraclePrimaryKeyFinderOnlineTest>OnlineTestCase.run:112->JDBCPrimaryKeyFinderOnlineTest.testAssignedSinglePKeyView:56 > » ClassCast > [ERROR] > OracleTypeNamesOnlineTest>OnlineTestCase.run:112->JDBCTypeNamesOnlineTest.testTypeNames:30 > » NullPointer > [INFO] > [ERROR] Tests run: 435, Failures: 2, Errors: 3, Skipped: 0 > [INFO] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 11:30 min (Wall Clock) > [INFO] Finished at: 2020-03-13T12:25:34+01:00 > [INFO] > ------------------------------------------------------------------------ > > > It seems 3D filtering does not work, when I execute > > SELECT A.* FROM LINE3D A > WHERE sdo_filter( A.GEOM, SDO_geometry( 3003, 4326, NULL, > SDO_elem_info_array( 1, 1003, 3 ), SDO_ordinate_array( 2, 1, 100, 3, 2, 101 > ) ) ) = 'TRUE'; > > Which is what I think the failing > Oracle3DOnlineTest>OnlineTestCase.run:112->JDBCGeneric3DOnlineTest.testBBOX3DOutsideLine:181 > should be doing I also get both/all records returned. > > btw. I'm using "Oracle Oracle Database 12c Enterprise Edition Release > 12.2.0.1.0 - 64bit Production" FWIW > > -M > > Op vr 13 mrt. 2020 om 10:42 schreef Ian Turton <ijtur...@gmail.com>: > >> The 2nd error is saying that something it expected to write to is read >> only. >> >> Ian >> >> On Thu, 12 Mar 2020 at 17:39, Mark Prins <mc.pr...@gmail.com> wrote: >> >>> I've started factoring out the deprecations and seeing some test >>> failures that don't seem related. >>> So I'm curious if anybody ran the oracle online tests recently? and if >>> there are known failures. >>> >>> Notably: >>> >>> =1= >>> a failing test: Oracle3DOnlineTest#testBBOX3DOutsideLine() inherited >>> from JDBCGeneric3DOnlineTest >>> >>> I see some WARNING messages in the output log about "3 dimensioned >>> geometry provided. This encoder only supports 2D linestring geometries. >>> The query will be constructed as a 2D query." so I'm wondering if this >>> is expected because a 2D filter is used instead of a 3D >>> >>> =2= >>> I see some messages "java.lang.ClassCastException: >>> org.geotools.jdbc.JDBCFeatureSource cannot be cast to >>> org.geotools.jdbc.JDBCFeatureStore" >>> >>> when the OraclePrimaryKeyFinderOnlineTest runs (all cases fail for that >>> test) >>> >>> =3= >>> I'm getting a NPE on the datastore in >>> OracleTypeNamesOnlineTest#testTypeNames() that inherits from >>> JDBCTypeNamesOnlineTest >>> >>> any hints or experiences are welcome; >>> (I have yet to try and see the results with master) >>> >>> Mark >>> >>> >>> On 09-03-2020 14:03, Mark Prins wrote: >>> > Created: >>> > - https://osgeo-org.atlassian.net/browse/GEOT-6529 >>> > - https://osgeo-org.atlassian.net/browse/GEOS-9535 >>> > >>> > Will follow up on those issues with PR's ASAP >>> > >>> > Mark >>> > >>> > >>> > On 02-03-2020 19:12, Jody Garnett wrote: >>> >> A PR would be great, and we can include the *Oracle Free Use Terms and >>> >> Conditions (FUTC)* license in the extension if that is what is >>> required. >>> >> >>> >> Also individual extensions can make notices in the server status >>> >> modules tab, if they want to report availability of a library, or >>> link >>> >> to some license notice (if that is required in the running >>> application). >>> >> -- >>> >> Jody Garnett >>> >> >>> >> >>> >> On Mon, 2 Mar 2020 at 02:45, Mark Prins <mc.pr...@gmail.com >>> >> <mailto:mc.pr...@gmail.com>> wrote: >>> >> >>> >> On 13-12-2019 11:08, Jody Garnett wrote: >>> >> > Following up on last meetings discussion on supporting oracle: >>> >> Oracle >>> >> > JDBC drivers on Maven Central >>> >> > >>> >> >>> >> < >>> https://medium.com/oracledevs/oracle-jdbc-drivers-on-maven-central-64fcf724d8b> >>> >>> >> >>> >> > >>> >> > Based on the I would like to remove the manual process of >>> >> installing >>> >> > ojdbc7 into your local repo, and replace with something like: >>> >> > >>> >> > <dependency> >>> >> > <groupId>com.oracle.ojdbc</groupId> >>> >> > <artifactId>ojdbc8</artifactId> >>> >> > <version>19.3.0.0</version> >>> >> > </dependency> >>> >> > >>> >> > Can I ask if anyone is using odjbc8 already? >>> >> >>> >> I don't think this happened yet has it? >>> >> >>> >> Oracle's first try at using Maven central was nearly succesful; >>> >> advancing insights made them decide to move the drivers to diffent >>> >> groupId's as described in the post om medium [1] >>> >> >>> >> the TLDR: >>> >> - all versions now available (19.3.0.0, 18.3.0.0, 12.2.0.1 and >>> some >>> >> 11.2.0.4) >>> >> - new groupId for production jar's at com.oracle.database.jdbc >>> >> - net groupId for debug jars (postfixed with _g) at >>> >> com.oracle.database.jdbc.debug >>> >> - all have sources + javadoc jar's as required >>> >> >>> >> so above snippet should be >>> >> >>> >> <dependency> >>> >> <groupId>com.oracle.database.jdbc</groupId> >>> >> <artifactId>ojdbc8</artifactId> >>> >> <version>19.3.0.0</version> >>> >> </dependency> >>> >> >>> >> for production use, or >>> >> >>> >> <dependency> >>> >> <groupId>com.oracle.database.jdbc.debug</groupId> >>> >> <artifactId>ojdbc8_g</artifactId> >>> >> <version>19.3.0.0</version> >>> >> </dependency> >>> >> >>> >> for debugging. >>> >> >>> >> I can prepare a PR if you like. >>> >> >>> >> Not sure where to a a note about the license "Oracle Free Use >>> >> Terms and >>> >> Conditions (FUTC)" >>> >> (I think that would only concern geoserver as that would/could >>> >> distribute the driver jar with the extension. Some lawyer should >>> >> decide >>> >> on that I guess.) >>> >> >>> >> [1] >>> >> >>> >> >>> https://medium.com/@kuassimensah/all-in-and-new-groupids-oracle-jdbc-drivers-on-maven-central-a76d545954c6 >>> >> >>> >> >>> >> >>> >> >>> >> >>> >> _______________________________________________ >>> >> GeoTools-Devel mailing list >>> >> GeoTools-Devel@lists.sourceforge.net >>> >> <mailto:GeoTools-Devel@lists.sourceforge.net> >>> >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >> >>> > >>> >>> >>> >>> _______________________________________________ >>> GeoTools-Devel mailing list >>> GeoTools-Devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >> >> >> -- >> Ian Turton >> > > > -- > Disclaimer; > This message is just a reflection of what I thought at the time of > sending. The message may contain information that is not intended for you > or that you don't understand. > -- Disclaimer; This message is just a reflection of what I thought at the time of sending. The message may contain information that is not intended for you or that you don't understand.
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
