Hi, I'm the CSS module maintainer. Had a look at the changes. The GeoTools change seems legit, it could be accepted if it's contributed according to procedure (CLA, tests, documentation updates).
The GeoServer one seems to forcefully give a unique name to rules, if they don't have one already. We don't do that for SLD, it should not be done for other style languages either. Unless I'm misunderstanding it, I'm not inclined to accept such a change, but let's talk. Best regards Andrea On Fri, Feb 2, 2024 at 2:23 PM Segerstedt, Peter via GeoTools-Devel < geotools-devel@lists.sourceforge.net> wrote: > Dear developers, > > I've made, on the behalf of a customer, small additions to geotools and > geoserver in order to solve what's been previously discussed here: > > > https://gis.stackexchange.com/questions/452624/name-property-for-rules-in-css-styles-alternatives-or-how-to-contribute > https://sourceforge.net/p/geoserver/mailman/message/36050785/ > > The code should be publicly available here: > https://github.com/sweco-sepesd/geoserver/tree/geoserver_css_name_rule > ( > https://github.com/sweco-sepesd/geoserver/commit/7ed3780e377dcb0318bf9f44be2420d2f53d2639 > ) > > https://github.com/sweco-sepesd/geotools/tree/css_named_rule > ( > https://github.com/sweco-sepesd/geotools/commit/2a4d1afcbb6fac7ac9c7798946db50a627aff119 > ) > > Under what circumstances would it be possible for geotools/geoserver to > adopt these changes? > > Best Regards, > > Peter Segerstedt > > > > > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 https://www.geosolutionsgroup.com/ http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
