Hi Peter, as a rule of thumb, we don't allow customer specific code in the GeoTools/GeoServer codebase, if we did, we'd end up accumulating a massive amount of of variants in the code that would make it even harder to maintain. The GeoServer changes look like a band-aid, too.
Now, I think I get why you want unique names, but rather than working around it in GeoServer, couldn't you have a CSS directive "@uniqueRules" in the CSS, that when used, makes the CSS translator generate unique names directly? Also, again for the "not for one customer" rule, the functionality should be properly documented to allow other users to make use of it (how to use it, why it's there). Try to write this documentation first, and if it's convincing for a wider audience, then I see no problem in integrating the changes in the GeoTools CSS module. Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 https://www.geosolutionsgroup.com/ http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail On Fri, Mar 1, 2024 at 12:51 PM Segerstedt, Peter <peter.segerst...@sweco.se> wrote: > Thank you very much for the quick answer, things are rolling a bit slower > on this side. > > We’ll go ahead and polish the geotools proposal according to the procedure > so that rule-names can be populated from the css. > > However, for the application/usage scenario in quest, it’s crucial that > the rule names end up being unique. > The reason is that, depending on the current zoom-level in combination > with other choices in the application, we need to fine tune what rules are > rendered by the GetLegendGraphic-request. > > We are aware of the SCALE-parameter, but that is not sufficient in our > case, we need to specify the RULE-parameter as well. > > The css-to-sld transformation is very likely to produce a number of > "sld-rule-permutations" out of a single css-rule so even if we implement > the part in geotools, where @name is parsed from the css, the generated > SLD-rules will in many cases not end up being "unique in the context in > which they are defined"*. > > * https://portal.ogc.org/files/?artifact_id=22364 page 27 > > We've thought so far of two additional constraints: > > 1. Only apply "make-names-unique"-routine if there was a @name in the css. > 2. Make the "make-names-unique"-routine optional and activated based on > some setting, perhaps system property. > > What do you think - Would any of these suggested constraints make any > difference? > > Best Regards, > > Peter Segerstedt > > From: Andrea Aime <andrea.a...@geosolutionsgroup.com> > Sent: Friday, February 2, 2024 6:23 PM > To: Segerstedt, Peter <peter.segerst...@sweco.se> > Cc: geotools-devel@lists.sourceforge.net; Persson, Marcus < > marcus.pers...@sweco.se>; david.pers...@eskilstuna.se > Subject: Re: [Geotools-devel] Regarding naming of rules derived from css > > Hi, > I'm the CSS module maintainer. Had a look at the changes. The GeoTools > change seems legit, it could be accepted > if it's contributed according to procedure (CLA, tests, documentation > updates). > > The GeoServer one seems to forcefully give a unique name to rules, if they > don't have one already. > We don't do that for SLD, it should not be done for other style languages > either. > Unless I'm misunderstanding it, I'm not inclined to accept such a change, > but let's talk. > > Best regards > Andrea > > > On Fri, Feb 2, 2024 at 2:23 PM Segerstedt, Peter via GeoTools-Devel > <mailto:geotools-devel@lists.sourceforge.net> wrote: > Dear developers, > > I've made, on the behalf of a customer, small additions to geotools and > geoserver in order to solve what's been previously discussed here: > > > https://urldefense.com/v3/__https://gis.stackexchange.com/questions/452624/name-property-for-rules-in-css-styles-alternatives-or-how-to-contribute__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz3FPtBZwU$ > > https://urldefense.com/v3/__https://sourceforge.net/p/geoserver/mailman/message/36050785/__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz3esziWDI$ > > The code should be publicly available here: > > https://urldefense.com/v3/__https://github.com/sweco-sepesd/geoserver/tree/geoserver_css_name_rule__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz3w1s0OxE$ > ( > https://urldefense.com/v3/__https://github.com/sweco-sepesd/geoserver/commit/7ed3780e377dcb0318bf9f44be2420d2f53d2639__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz3FbMb_8w$ > ) > > > https://urldefense.com/v3/__https://github.com/sweco-sepesd/geotools/tree/css_named_rule__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz39_OE9-A$ > ( > https://urldefense.com/v3/__https://github.com/sweco-sepesd/geotools/commit/2a4d1afcbb6fac7ac9c7798946db50a627aff119__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz3G7Ddl-c$ > ) > > Under what circumstances would it be possible for geotools/geoserver to > adopt these changes? > > Best Regards, > > Peter Segerstedt > > > > > _______________________________________________ > GeoTools-Devel mailing list > mailto:GeoTools-Devel@lists.sourceforge.net > > https://urldefense.com/v3/__https://lists.sourceforge.net/lists/listinfo/geotools-devel__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz3ZZJYxcw$ > > > > -- > Regards, > Andrea Aime > == > GeoServer Professional Services from the experts! > Visit > https://urldefense.com/v3/__http://bit.ly/gs-services-us__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz3wDg4WZ8$ > for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > GeoSolutions Group > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > > https://urldefense.com/v3/__https://www.geosolutionsgroup.com/__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz3C9cwAbU$ > > https://urldefense.com/v3/__http://twitter.com/geosolutions_it__;!!HBVxBjZwpQ!wdN6haywN-0oMAqZAJScSYxbrRd78x11DMc-THOhPNxJsj7Qf8oOEqYL2MRt1R00SsIM9AAOqZIYZm-u1PIeonSdwrz3iPZYfYU$ > ------------------------------------------------------- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail >
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
