Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/2655/2//COMMIT_MSG Commit Message: Line 10: returning -1 I'm not sure if this is consistent with the existing APIs inside OpenGGSN. It is a stylistic decision if you always return -1 and then have the caller resolve errno, or if you return an error code. While the native osmocom projects prefer the latter, this may not be the case with OpenGGSN. Please make sure we're consistent with the code (I don't know this off my head). -- To view, visit https://gerrit.osmocom.org/2655 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07f1e4246eb178838b7df21946a08a1f60f2084 Gerrit-PatchSet: 2 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
