Patch Set 7: (3 comments)
some replies... https://gerrit.osmocom.org/#/c/2465/7/scripts/osmo-build.sh File scripts/osmo-build.sh: Line 86: job_name="${JOB_NAME//\//#}" > It replaces '/' with '#' to avoid slashes in the artifact filename. Will ad Ah, this is a bash-ism that I don't know. My personal preference would be to stay with /bin/sh bounds ... fine then. Aren't '#' in file names rather unusual, given that they are comment delimiters? how about underscores, double-underscores or maybe a comma? Line 171: rm -f "$job_store/*" > True, I somehow relied on the assumption that job B, which has been trigger there's also the parallel matrix builds? do they each have a separate artifact store? If they share, builds of the same matrix may GC away artifacts the other has just built, or something in that line. Line 187: generateArtifactHashes "$1" > >> And about the GC problem above: the most waterproof let's try to keep the algorithm completely timing-free, i.e. do not rely on x amount of time having passed. Atomicity should suffice, right? -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f810234d5452e47484 Gerrit-PatchSet: 7 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: blobb <dr.bl...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: blobb <dr.bl...@gmail.com> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
