Patch Set 10: Code-Review-1 (1 comment)
Please do not submit. all --enable-iu axes [1] are failing. [1] https://jenkins.blobb.me/job/openBSC_multi-configuration_withArtifacts_testRefactoring/ https://gerrit.osmocom.org/#/c/2465/8/scripts/osmo-build.sh File scripts/osmo-build.sh: Line 1: #!/bin/bash > Why bash and not sh? Do you use bash-specific features? Yes e.g. line echo 175 "$1.${branch//\//#}.${rev:0:7}" ${branch//\//#} -> replace '/' with '#' ${rev:0:7} -> substring[0;7] -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f810234d5452e47484 Gerrit-PatchSet: 10 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: blobb <dr.bl...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: blobb <dr.bl...@gmail.com> Gerrit-HasComments: Yes
