Patch Set 3: Code-Review-1 (1 comment)
In general, I'd prefer to avoid confusion with generated code which is in files ending with _gen.* as well. Calling it viterbi_generic.c would be much better. https://gerrit.osmocom.org/#/c/2760/3/src/viterbi_gen.c File src/viterbi_gen.c: Line 145: void osmo_conv_gen_metrics_k5_n2_gen(const int8_t *seq, const int16_t *out, Why the double _gen in the name? And why do we have to rename it at all? -- To view, visit https://gerrit.osmocom.org/2760 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I042cc76258df7e4c6c90a73af3d0a6e75999b2b0 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Alexander Chemeris <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Tom Tsou <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-HasComments: Yes
