Patch Set 3: (1 comment)
> I think it'a better to use a different extension for the include > file - not .c. In C++ you would use .ipp (inline cpp) extension, > but I don't know whether a similar thing exist in C. See e.g. > http://julio.meroh.net/2013/12/header-files-c-ipp-files.html for > the way it's used in C++. I think we can use .h, because the file mostly consists of defines and several inline functions. https://gerrit.osmocom.org/#/c/2760/3/src/viterbi_gen.c File src/viterbi_gen.c: Line 145: void osmo_conv_gen_metrics_k5_n2_gen(const int8_t *seq, const int16_t *out, > Why the double _gen in the name? And why do we have to rename it at all? Done, thanks! -- To view, visit https://gerrit.osmocom.org/2760 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I042cc76258df7e4c6c90a73af3d0a6e75999b2b0 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Alexander Chemeris <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Tom Tsou <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-HasComments: Yes
