Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/2783/1/openbsc/src/libbsc/abis_nm.c File openbsc/src/libbsc/abis_nm.c: Line 495: sw_len = ari_len - (unreported + 2); This code is way too complex and hand-crafted for my taste, sorry. We have magic offsets that get added in some places and subtracted in other places. I really don't understand what you're doing her and why we cannot have a clean interface to parse the messages, like we have in many other places. Line 498: if (TLVP_PRESENT(&tp, NM_ATT_MANUF_STATE)) { the presence of the attribute does not imply it has a length > 0. -- To view, visit https://gerrit.osmocom.org/2783 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b61131b9930afd03357c0b66947ee856d58cc46 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
