Patch Set 5: (1 comment)
https://gerrit.osmocom.org/#/c/2783/5/openbsc/src/libbsc/abis_nm.c File openbsc/src/libbsc/abis_nm.c: Line 487: LOGP(DNM, LOGL_NOTICE, "Get Attributes Response: BTS%u/TRX%u nominal power is %u\n", we have gsm_trx_name() and should probably use it. Or, if we want to print this even for non-existing TRX, we should use the same format as gsm_trx_name() to ensure existing regular expressions/grep will catch this in the same manner like all other messages for that trx. -- To view, visit https://gerrit.osmocom.org/2783 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b61131b9930afd03357c0b66947ee856d58cc46 Gerrit-PatchSet: 5 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
