laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 )
Change subject: TRXD: add documentation for TRXDv2 protocol ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867/4/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867/4/common/chapters/trx_if.adoc@738 PS4, Line 738: different with different from what? I think something like "the ordering of TRXN within the PDUs of one batch is not required to be ascending/monotonic" or something like that. But "different" can only be used if you specify from what it is different. You could also state "The orddering of [TRXN in the] PDUs may be different from the example below." https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867/4/common/chapters/trx_if.adoc@742 PS4, Line 742: packet as UDP may at least in theory be fragmented over multiple packets, I suggest to use "datagram" which is (AFAIR) the terminology used in UDP. We of course want no fragmentation for performance reason, but we should still try to use language as precise as possible. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I03b2beeb535848b31fd629ba3cd330b43072c08b Gerrit-Change-Number: 22867 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 12 Apr 2021 08:16:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
