fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 )
Change subject: TRXD: add documentation for TRXDv2 protocol ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867/5/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867/5/common/chapters/trx_if.adoc@516 PS5, Line 516: RFU: variable bit-length:: Ok, the commit message I referred to does not explain why it becomes variable length, sorry. But it mentions that RFU will appear in several places: in diagram 'Uplink message structure (batched part)' above RFU takes 4 bits. But in 'Downlink PDU structure (batched part)' I forgot to replace VER with RFU - will correct soon. > according to packetdiab above it's one byte Are you sure you are not referring to an earlier version of this patch? In the latest version it's either 1 bit (between VER and TN) or 5 bit (replacing VER in the batched part). -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I03b2beeb535848b31fd629ba3cd330b43072c08b Gerrit-Change-Number: 22867 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 14 Apr 2021 15:32:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
