Attention is currently required from: iedemam, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28165 )
Change subject: stats: new trackers for lchan life duration (v2) ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/6b68def6_757c98bf PS3, Line 519: .active_start = { .tv_sec = 0, .tv_nsec = 0 }, > The purpose of this was to initialize the timestamps to zero values so I can > tell when they've been […] My point is simply that this struct initializer is already zeroing all fields in the struct unless otherwise specified, that's why most of the struct fields don't appear here. So there's no need to set them to 0 explicitly, they are set to zero anyway, so they can be removed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie3771233ecbd4bc24a24fb22c1064a18e7b8b2b0 Gerrit-Change-Number: 28165 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: iedemam <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Mon, 23 May 2022 08:48:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: iedemam <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
