Attention is currently required from: neels, pespin.
iedemam has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/28165 )

Change subject: stats: new trackers for lchan life duration (v2)
......................................................................


Patch Set 4:

(2 comments)

Patchset:

PS4:
Small cleanup, thanks for the reviews.

I'm still waiting for an opportunity to push this to a loaded BSC to get 
another set of perf measurements and confirm overall accuracy.


File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/b6cfbd68_6844c0ca
PS3, Line 519:          .active_start = { .tv_sec = 0, .tv_nsec = 0 },
> My point is simply that this struct initializer is already zeroing all fields 
> in the struct unless o […]
Ah, apologies. Now I see it, thanks.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28165
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3771233ecbd4bc24a24fb22c1064a18e7b8b2b0
Gerrit-Change-Number: 28165
Gerrit-PatchSet: 4
Gerrit-Owner: iedemam <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 23 May 2022 09:24:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to