Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 )

Change subject: add option to send SCCP CR without payload
......................................................................


Patch Set 3:

(1 comment)

File src/osmo-hnbgw/hnbgw_rua.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/677c0f84_7260cada
PS1, Line 274:  if (data && len && map && !map->is_ps && !release_context_map) {
> Because ranap_cn_rx_co_decode() crashes when there is no payload data.
So data is already checked above in line 267, which means this should have 
already been in place before your current patch. Please submit a different 
patch for this fix, agree?



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328
Gerrit-Change-Number: 28230
Gerrit-PatchSet: 3
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Tue, 07 Jun 2022 16:50:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to