Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 )
Change subject: add option to send SCCP CR without payload ...................................................................... Patch Set 5: Code-Review+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/f8aa57d1_6e6fe242 PS1, Line 27: a separate SCCP CR without payload. > Sure. […] I think a size boundary is more useful than a bool Patchset: PS2: > May make sense indeed. Agreed (library is best). But let's either merge this quickly and revert later or do a"next" branch build from this to enable the user to quickly validate this from a Debian package asap File src/osmo-hnbgw/hnbgw.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/628049ae_03201435 PS1, Line 93: gw->config.max_sccp_cr_payload_len = 999999; > on the VTY, we often use max values like 99999, that's the only reason. […] The actual maximum SCCP. Size is constrained at a much mower length, see the sysmocom issue where I searched the specs for it. You will never even see anywhere near 1000 afaict. So let's use s more spec relevant value? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328 Gerrit-Change-Number: 28230 Gerrit-PatchSet: 5 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 08 Jun 2022 01:12:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
