Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 )
Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File bsc/BSC_Tests_CBSP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/19761fbc_7d396614 PS2, Line 15: import from BSC_Tests all; > I changed it here on purpose since it's somehow a special case, since we are > basically extending fro […] I am still not convinced why it makes sense, sorry. We're simply using some API from BSC_Tests. Just like we use API from the other modules, there is nothing special about that. This patch is about adding f_shutdown_helper() to address sporadic failures, and regardless of my opinion on reordering imports this is an unrelated change. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe Gerrit-Change-Number: 28406 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 23 Jun 2022 11:08:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
