Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406 )

Change subject: bsc: Call f_shutdown_helper() in BSC_Tests_CBSP tests
......................................................................


Patch Set 2:

(1 comment)

File bsc/BSC_Tests_CBSP.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406/comment/68c6bbde_b7806bfe
PS2, Line 15: import from BSC_Tests all;
> Some further differences: […]
As I said, this is an unrelated change. I am against mixing up questionable 
changes into the real fixes and merging everything together. If you insist on 
doing reordering, then please propose it in a separate change and also update 
the other friend modules (like BTS_Tests_VAMOS and BTS_Tests_SMSCB) to avoid 
the inconsistency.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28406
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5ddce5cfcbfb057b4559a5d5a710d218bae1d8fe
Gerrit-Change-Number: 28406
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 23 Jun 2022 11:28:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to