Attention is currently required from: msuraev, dexter.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28846 )

Change subject: Make esme struct shared
......................................................................


Patch Set 18:

(1 comment)

File src/libsmpputil/smpp_smsc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/9bd98785_3edc04a3
PS18, Line 879:         struct esme *e = talloc_zero(ctx, struct esme);
Ah now it is allocated here, good then.
But then the function should be called emse_alloc().



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 18
Gerrit-Owner: msuraev <msur...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: msuraev <msur...@sysmocom.de>
Gerrit-Attention: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Aug 2022 14:05:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to