Attention is currently required from: laforge, pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared ...................................................................... Patch Set 20: (2 comments) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/a92f05af_e8da2e61 PS19, Line 14: struct esme { > prefer 'struct smpp_esme' since it is from smpp. […] does that mean you disagree here? File include/osmocom/smpp/smpp_smsc.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/b06a9b74_d636e9bd PS19, Line 32: struct esme *esme; > Hi Neels, it's fine the way the patch is now, I actually pointed towards the > current directon, since […] there is a point at which hiding struct details is more of a hindrance than helping. When a struct is not public API of a library, IMHO it is better to openly share the structs than using opaque structs with tons of functions for every struct access, and dynamic allocations that cannot be optimized by the compiler. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 20 Gerrit-Owner: msuraev <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: msuraev <msur...@sysmocom.de> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 21:43:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
