Attention is currently required from: neels, laforge, pespin, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 )
Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 16: (14 comments) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/e310bcbb_d100f350 PS14, Line 1110: xua_opt_data_send_cache(conn, SUA_CO_CORE, xua->hdr.msg_class); > maybe i was misreading this code. […] Ack File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/fe2b440c_1c650313 PS15, Line 642: /* optional: importance */ > like i said before, a patch should ideally do one thing. […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/260bad71_8dd729c7 PS15, Line 600: if ( > Simply drop it then. Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/050a586c_5d9ec7ac PS15, Line 606: } else > not critical, but IMHO there should be curly braces. […] Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/73da6543_4b9fb0b5 PS15, Line 606: } else > not critical, but IMHO there should be curly braces. […] Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/3a90071f_211ad50f PS15, Line 635: LOGP(DLSCCP, LOGL_ERROR, "replacing unsent %u bytes of optional data cache with %s optional data\n", > I understand, this case is where we want to cache optional data, but there > already is other data in […] Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/87ac74a3_b8be3def PS15, Line 635: LOGP(DLSCCP, LOGL_ERROR, "replacing unsent %u bytes of optional data cache with %s optional data\n", > I understand, this case is where we want to cache optional data, but there > already is other data in […] Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7138c7ce_a9fe6137 PS15, Line 784: xua_msg_add_sccp_addr(xua, SUA_IEI_DEST_ADDR, &conn->calling_addr); > Then write a new comit "comments are placed to match the fields order in the > spec. […] Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/b8ad7bb9_9260bd9a PS16, Line 592: nt exp_type > could you explain a situation where there might be a mismatch from the > expected type? Isn't it alway […] Both expected types refer to the message which was source of the optional data. This check is simply an additional safeguard to ensure we hadn't screwed up while adjusting FSM. The caching happens in one place, sending in another but we always know what kind of Optional Data we're about to send (i. e. from which message it was cached). So here we compare the type of the message as recorded while caching with the type of the message FSM thinks it's sending. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/441d202f_57a781cb PS16, Line 638: msgb_trim(conn->opt_data_cache, 0); > (i'd prefer sanitation: msgb_free() here, and always alloc a new one. […] I don't: if msgb_trim() is implemented properly there should be no difference in our case (fixed buffer size) besides wasted CPU cycle on unnecessary function calls. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d2098370_4a00e0bd PS16, Line 667: see Figure C.3 / Q.714 (sheet 2 of 6) */ > (osmocom asks to put '*' on every line of comment) Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/994a5e32_94ddf4ec PS16, Line 673: if (xua_drop_data_check_drop(prim, SCCP_MAX_DATA, "cache overrun")) > the optional data is larger than the upper limit of an SCCP DATA section -- > this is not related to c […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/5099038f_2e5fe8c1 PS16, Line 675: /* There's no need to cache the optional data since the connection is still active at this point */ > /* Send the Optional Data in a DT1 ahead of the RLSD, because it is too large > to be sent in one mess […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/b2b8d5d3_9fe7a406 PS16, Line 712: ount > (again modifying unrelated comments) Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 16 Gerrit-Owner: msuraev <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:37:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: msuraev <msur...@sysmocom.de> Gerrit-MessageType: comment
