Attention is currently required from: neels, pespin.
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 )

Change subject: BSC: add TC_ho_meas_rep_multi_band
......................................................................


Patch Set 3:

(2 comments)

File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837/comment/c42279df_b49e8d8d
PS2, Line 11987:         * correctly, the third entry has LAC 97. Before this 
was fixed, the
> Better drop the "before" references completely, that's mostly adding 
> information about wrong behavio […]
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837/comment/a7f141c5_a08d8d4c
PS2, Line 12013:        f_bts_0_cfg(BSCVTY,
> don't you need to reset this at some point?
Good question. I've copied most of this test from TC_ho_out_of_this_bsc and 
adjusted it, so if that cleans up properly, this test should too. But I don't 
see where it resets the bts 0 cfg, maybe it is missing there as well. Maybe 
Neels can comment on this?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286
Gerrit-Change-Number: 29837
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Oct 2022 14:52:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to