Attention is currently required from: neels, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 )
Change subject: BSC: add TC_ho_meas_rep_multi_band ...................................................................... Patch Set 3: (1 comment) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837/comment/856d721e_5b3df68c PS3, Line 898: cid_list := * > This parameter should be '(present)' and set to '?' by default, because > PDU_BSSMAP_HandoverRequired. […] Wouldn't this break existing code using this? $ git grep tr_BSSMAP_HandoverRequired BSC_Tests.ttcn: BSSAP.receive(tr_BSSMAP_HandoverRequired(exp_oldToNewBSSIEs)); BSC_Tests.ttcn: BSSAP.receive(tr_BSSMAP_HandoverRequired); BSC_Tests.ttcn: BSSAP.receive(tr_BSSMAP_HandoverRequired); BSC_Tests.ttcn: BSSAP.receive(tr_BSSMAP_HandoverRequired); BSC_Tests.ttcn: [] BSSAP.receive(tr_BSSMAP_HandoverRequired) { BSC_Tests.ttcn: [] BSSAP.receive(tr_BSSMAP_HandoverRequired(cid_list := cid_list)) { BSC_Tests.ttcn: [] BSSAP.receive(tr_BSSMAP_HandoverRequired()) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286 Gerrit-Change-Number: 29837 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 11:28:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
