Attention is currently required from: laforge, pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 )
Change subject: libosmonetify SMPP ...................................................................... Patch Set 57: (4 comments) File src/libsmpputil/smpp_msc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/a1a8b9d7_5537ec00 PS57, Line 849: The bad side of using auto-formatting :) File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/0fd4aa27_7eeae12a PS49, Line 347: osmo_stream_srv_send(esme->srv, msg); > Yes? osmo_stream_srv_send() returns no value... File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/012cac07_f5a7e68a PS57, Line 767: return -ENOMEM; I know it's unlikely that msgb_alloc() would return NULL, but still: shouldn't we close the connection here? libosmonetif has some data for you, so it calls your callback, but you don't read() from socket. Data is still there, so I guess it will keep calling your callback again and again? https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/1e47a141_65cde513 PS57, Line 855: lost I would say 'closed', because 'lost' sounds like things went wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 Gerrit-Change-Number: 28849 Gerrit-PatchSet: 57 Gerrit-Owner: msuraev <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: msuraev <msur...@sysmocom.de> Gerrit-Comment-Date: Sun, 20 Nov 2022 22:33:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: msuraev <msur...@sysmocom.de> Gerrit-MessageType: comment
