Attention is currently required from: pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30293 )
Change subject: pdch: Initial support Handling PktResReq with ID_TYPE=UL/DL_TFI ...................................................................... Patch Set 3: (3 comments) Patchset: PS3: LGTM except our linter is sleeping again. I guess we don't have tttcn3 or unit tests covering this? File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30293/comment/a5548643_fdbdd6b0 PS3, Line 740: /* If MS identified by TLLI sent us a PktResReq through SBA, it means it came some small indention errors. https://gerrit.osmocom.org/c/osmo-pcu/+/30293/comment/08131f92_521a143b PS3, Line 750: /* Similarly, it is for sure not using any DL-TBF. We some small indention errors. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie6b1b438d26cd977f88ddb4eff6b3041e0739d92 Gerrit-Change-Number: 30293 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: msuraev <msur...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 15:49:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment