Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30293 )
Change subject: pdch: Initial support Handling PktResReq with ID_TYPE=UL/DL_TFI ...................................................................... Patch Set 3: (3 comments) Patchset: PS3: > LGTM except our linter is sleeping again. […] TTCN3: Not yet for the new scenario, it is part of the TODO of the ticket. Mind this doesn't aim to fully fix the situation, since doing so requires more work in several places to make sure everything is fine. File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30293/comment/c129002a_3673380b PS3, Line 740: /* If MS identified by TLLI sent us a PktResReq through SBA, it means it came > some small indention errors. Ack https://gerrit.osmocom.org/c/osmo-pcu/+/30293/comment/fa51db03_9a0c33bb PS3, Line 750: /* Similarly, it is for sure not using any DL-TBF. We > some small indention errors. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie6b1b438d26cd977f88ddb4eff6b3041e0739d92 Gerrit-Change-Number: 30293 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: msuraev <msur...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Tue, 29 Nov 2022 15:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu> Gerrit-MessageType: comment