Attention is currently required from: Hoernchen, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30337 )
Change subject: mobile: integrate GAPK based audio (voice) I/O support ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: I think it's currently lacking some effective control to avoid unbounded buffer queue growth (sorry if I missed it) The sample clock of your ALSA device and the GSM frame clock will inevitably have independent sources, and one will be running faster than the other. If the GSM clock is faster than your audio clock, your buffer queue will grow more and more, and audio delay increase. A simple hack might be to have a limit for the queue. We'd then drop a frame once it overflows. Maybe that's "good enough" for a first implementation, and simple enough to do already in the initial version of the patch The smarter approach would of course be to simply drop some of the decoded audio samples here or there before playing them, causing smaller/shorter disruptions in the audio. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-Attention: Hoernchen <ew...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 29 Nov 2022 07:29:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
