Attention is currently required from: Hoernchen, fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/30337 )

Change subject: mobile: integrate GAPK based audio (voice) I/O support
......................................................................


Patch Set 5:

(1 comment)

File src/host/layer23/src/mobile/gapk_io.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/30337/comment/bf0368ff_8481cb55
PS5, Line 528:  ll
using llist_count() would probably be more easy to read/understand rather than 
open-coding it by hand here (and optimizing for the >2 case).  Just a random 
comment, not critical.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9
Gerrit-Change-Number: 30337
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: fixeria <axilira...@gmail.com>
Gerrit-Attention: Hoernchen <ew...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Nov 2022 10:28:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to