Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 )
Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/7c1293f2_d2b0c38e PS1, Line 263: bts_pag_st->initial_req_list_len--; > You already adjust the *_list_len accordingly in paging_remove_request(). […] So you basically suggesting to move the -- and ++ lines inside paging_req_timeout_trans() within a "if (req->attempts==0)" conditional block, right? So same behavior in the end, just different place. I can do that, it may be clearer for people when reading the lifecycle of requests across the different lists. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillm...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:10:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillm...@sysmocom.de> Gerrit-MessageType: comment
