Attention is currently required from: laforge, daniel.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30363 )

Change subject: paging: Split paging queue into 2 queues: initial and retrans
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/b75d13f9_13897a75
PS1, Line 1045: static void paging_dump_vty(struct vty *vty, struct 
gsm_paging_request *pag)
              : {
              :         vty_out(vty, "Paging on BTS %u%s", pag->bts->nr, 
VTY_NEWLINE);
              :         bsc_subscr_dump_vty(vty, pag->bsub);
              : }
              :
              : static void bts_paging_dump_vty(struct vty *vty, struct gsm_bts 
*bts)
              : {
              :         struct gsm_paging_request *pag;
              :
              :         llist_for_each_entry(pag, 
&bts->paging.initial_req_list, entry)
              :                 paging_dump_vty(vty, pag);
              :         llist_for_each_entry(pag, 
&bts->paging.retrans_req_list, entry)
              :                 paging_dump_vty(vty, pag);
> minor (can be follow-up patch): It might make sense to extend the vty dumping 
> with some information  […]
Will be submitted as Change-ID I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747
Gerrit-Change-Number: 30363
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillm...@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Attention: daniel <dwillm...@sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 13:27:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Gerrit-MessageType: comment

Reply via email to