Attention is currently required from: neels, keith, daniel, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )
Change subject: Add vty `reject-cause` to set the reject cause ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: I'm not against merging this patch, but I'm raising the topic since we seem to merging a feature which is actually meant only to "do some tests to find out real behavior", so it's not something users will need in the end. If you have a specific case in dGSM where you'd like to change the returned cause based on case "1" or "2" you described, that should be done in the code automatically without need for the user to configure it. I'd like to hear motivations from @lynxis too regarding this patch. If others are fine with merging this then feel free to merge. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: keith <ke...@rhizomatica.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: keith <ke...@rhizomatica.org> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Thu, 19 Jan 2023 11:15:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
