Attention is currently required from: neels, pespin, daniel, lynxis lazus. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )
Change subject: Add vty `reject-cause` to set the reject cause ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: > I'm not against merging this patch, but I'm raising the topic since we seem > to merging a feature whi […] and I'm not against keeping the functionality clean, and I'm all for questioning the need for patches and for hearing more voices on it. That said, I'm stumped to know how the code would automatically know on which site the operator would like to reject [not found at this time in dGSM] IMSIs with CONGESTION and on which sites with "ROAMING NOT ALLOWED". Maybe if I include libosmo-chatgpt.h ;-) Also, I don't see that this patch, or any other for that matter, that does not change default behaviour, but rather adds an OPTIONAL vty param that the user is free to ignore, creates a need for the user to configure it. I am now more curious about what lynxis' motivation at 36c3 was. I sort of remember something about it. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: keith <ke...@rhizomatica.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Thu, 19 Jan 2023 16:31:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
