Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/31007 )
Change subject: modem: Initial integration of libosmo-gprs-{llc,sndcp}
......................................................................
Patch Set 5:
(3 comments)
File src/host/layer23/src/modem/app_modem.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/00747fcd_90d6ec12
PS5, Line 556: DLGLOBAL
DLLC?
https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/646802cb_8c487c73
PS5, Line 561: DLGLOBAL
DSNDCP?
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/2e1d0021_8168adeb
PS5, Line 68: //TODO: free msg?
intentionally keeping these?
there are more TODOs below, but these below look like they were kept on purpose.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31007
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I820328009ccdd1f8112aeb163efa064ec1465d2a
Gerrit-Change-Number: 31007
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 08:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
