Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/31007 )
Change subject: modem: Initial integration of libosmo-gprs-{llc,sndcp}
......................................................................
Patch Set 5:
(3 comments)
File src/host/layer23/src/modem/app_modem.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/8a2fc24c_b6ca829e
PS5, Line 556: DLGLOBAL
> DLLC?
Ack
https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/8d283926_ceefc137
PS5, Line 561: DLGLOBAL
> DSNDCP?
Ack
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/45d3f1f5_ea55a487
PS5, Line 68: //TODO: free msg?
> intentionally keeping these? […]
This is expected, all the message ownership stuff in the APIs will be looked at
once everything is in place, to see how we can optimize msgb allocation buffer
copying.
This app has still a lot of stuff missing so it's notr eady for normal use yet.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31007
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I820328009ccdd1f8112aeb163efa064ec1465d2a
Gerrit-Change-Number: 31007
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 11:44:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osm...@sysmocom.de>
Gerrit-MessageType: comment
