Attention is currently required from: pespin, fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31572 )
Change subject: modem: route L1CTL prims to/from libosmo-gprs-rlcmac ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/modem/rlcmac.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31572/comment/b9cae462_25034a49 PS1, Line 173: rlcmac_prim_l1ctl_alloc @pespin: I would like to be able to allocate RLCMAC_L1CTL primitives like this, instead of using functions like osmo_gprs_rlcmac_prim_alloc_l1ctl_pdch_data_ind(). One problem is that it's quite a long symbol name, which alone takes almost the entire line on my screen, so passing it several arguments would make it completely unreadable. The benefits of letting the user fill-in the prim structure are: * readability, as I already said above; * extensibility: once we add more fields, there would be no need to add `osmo_gprs_rlcmac_prim_alloc_l1ctl_pdch_data_ind{1,2,3,...}()`; * consistency with other osmo-API, like the L1SAP code. Would it be possible to expose `[osmo_gprs_]rlcmac_prim_l1ctl_alloc()`? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I38e9a686f8edc3fe55f961d75e68602c33bbbaaf Gerrit-Change-Number: 31572 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 16:08:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
