Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/31572 )

Change subject: modem: route L1CTL prims to/from libosmo-gprs-rlcmac
......................................................................


Patch Set 1:

(1 comment)

File src/host/layer23/src/modem/rlcmac.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/31572/comment/68b97d29_f24f8d3f
PS1, Line 173: rlcmac_prim_l1ctl_alloc
> ... which alone takes almost the entire line on my screen

Ok, this is not entirely true. It's more like 1/3 of the line (I use big font).
But still, passing multiple arguments to it looks like a mess.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31572
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I38e9a686f8edc3fe55f961d75e68602c33bbbaaf
Gerrit-Change-Number: 31572
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 16:11:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to