Attention is currently required from: neels, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 17: Code-Review-1 (6 comments) File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/de5fe3fe_854658d9 PS17, Line 48: #define PCU_IF_FLAG_DT (1 << 2)/* use TLLI for confirmation directly */ I think we agreed in the call this flag was not needed. https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/669099fc_aa3e5889 PS17, Line 280: uint8_t pgroup[3]; This can be a int16_t containing a number 0-999. https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/f86341bf_e27d3f4d PS17, Line 294: struct gsm_pcu_if_data_cnf_dt data_cnf_dt; isn't it a bit weird that we have a cnf_dt but no data_dt? File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/3c1259d6_37a48a0b PS17, Line 282: /* Use the TLLI directly to handle IMMEDIATE ASSIGNMENT confirmation, otherwise the TLLI is extracted This is most probably not needed anymore and can be dropped. File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/5d34526d_f3a0f307 PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf))); I thought we agreed on dropping the previous message? File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/eaf4a5b4_12c55936 PS17, Line 769: this can be dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 17 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:16:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
