Attention is currently required from: neels, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 19: (5 comments) File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/8cf4630a_56bc9d04 PS19, Line 279: uint8_t pgroup; isn't pgroup going 0-999? that doesn't fit in a 8bit one (256) File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/9dbd2666_6b5bb5ab PS19, Line 284: bool use_dt_confirm; I think it would be best to simply drop this bool, and explicitly check against received info_ind PCUIF version. File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/f3e67c16_20a00afd PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf))); > Here is the related ticket: https://osmocom. […] I like the idea of supporting both 0x0a and 0x0b in osmo-pcu, that's great. I edited this comment because I was proposing exactly that and found out it's implemented in the next file in gerrit. Great! File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/578fe4e7_3a8347c0 PS19, Line 769: LOGP(DL1IF, LOGL_NOTICE, "selected IMMEDIATE assignment confirmation method (MAC block as reference) is deprecated. OS#5927\n"); I think in here simply state that "PCUIF version 10 is deprecated" would be more interesting. https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/41a2c6e1_3bf49425 PS19, Line 771: } else { you cannot reach here according to if block in line 752. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 19 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Wed, 01 Mar 2023 18:14:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
