Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31610 )
Change subject: vty: msc / codec-list: forbid duplicate entries ...................................................................... Patch Set 1: (3 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/0c04234f_d42e1e86 PS1, Line 2730: || argv[i][1] != 'r' this indentation looks wrong. https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/3b06bb68_1103b6ee PS1, Line 2731: || (argv[i][0] != 'h' && argv[i][0] != 'f') comparing first argv[i][0] and after argv[i][1] is way more "expected" ;) https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/18f844c5_349f7874 PS1, Line 2740: if (strncmp("hr", argv[i], 2) == 0) tmp[i].hr = (argv[i][0] == 'h' ? 1 : 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifdc9e04bf1d623da65bfb8a2fddea765601f6d9b Gerrit-Change-Number: 31610 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 01 Mar 2023 13:53:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment