neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31610 )
Change subject: vty: msc / codec-list: forbid duplicate entries ...................................................................... Patch Set 2: (2 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/0e30a8ce_f6a7d5b3 PS1, Line 2730: || argv[i][1] != 'r' > yeah well, but while moving the code around you can move it using the proper > indentation ;) i prefer not to touch anything in moved code if at all possible. The indentation is not wrong, it is plain tab indenting, an acceptable way to indent. https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/44e9002b_b203ffa1 PS1, Line 2740: if (strncmp("hr", argv[i], 2) == 0) > Ok fine. […] "how"? nevermind =) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifdc9e04bf1d623da65bfb8a2fddea765601f6d9b Gerrit-Change-Number: 31610 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 16:20:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
