Attention is currently required from: dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/31636 )

Change subject: mgcp_e1: rename e1_send to e1_send_ts_frame
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
e1_ts_send_frame would be more logical, IMHO, as we typically tend to specify 
the "subject" (e1inp_ts) and then the action. But in any case, the new name is 
an improvement, and its just a static function, so no need to be super picky 
about it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31636
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I5fba7993860a63149a13d943edbfabc4008680ef
Gerrit-Change-Number: 31636
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Mar 2023 14:17:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to