Attention is currently required from: laforge, pespin.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31631 )

Change subject: bsc_test.c: test FSM IDs that contain pchan names
......................................................................


Patch Set 4:

(1 comment)

File tests/bsc/bsc_test.ok:

https://gerrit.osmocom.org/c/osmo-bsc/+/31631/comment/c07c2874_58ed1e2a
PS3, Line 50: pchan=OSMODYN:
> would be resolved if the name was changed (as I just requested in a different 
> patch comment)
I prefer "osmodyn" for reasons [...], and hence i want to make all of it 
"osmodyn" everywhere. (to clarify, the "OSMO_DYN" in line 53 is changed in an 
upcoming patch to "OSMODYN")

now we need to agree on a name that should then be used everywhere. my vote is 
still for "osmodyn", if others agree on a different name then i'll take that 
one. (It would pain me to have a separator in the name but i'm just one 
person...)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31631
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If369f23fa140b9d7792f5a511815cbbd14b371e9
Gerrit-Change-Number: 31631
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Mar 2023 17:15:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to