Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31631 )
Change subject: bsc_test.c: test FSM IDs that contain pchan names ...................................................................... Patch Set 4: -Code-Review (1 comment) File tests/bsc/bsc_test.ok: https://gerrit.osmocom.org/c/osmo-bsc/+/31631/comment/8fa63503_0981a8dd PS3, Line 50: pchan=OSMODYN: > I prefer "osmodyn" for reasons [...], and hence i want to make all of it > "osmodyn" everywhere. […] I personally prefer having "-" or "_" in it, I agree with Harald that "OSMODYN" looks difficult to understand. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If369f23fa140b9d7792f5a511815cbbd14b371e9 Gerrit-Change-Number: 31631 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
