Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/31572 )

Change subject: modem: route L1CTL prims to/from libosmo-gprs-rlcmac
......................................................................


Patch Set 3:

(1 comment)

File src/host/layer23/src/modem/rlcmac.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/31572/comment/1c34a283_da14d3b4
PS3, Line 131:                                                
lp->pdch_data_req.ts_nr,
> You may find it weird, but I like it this way and I prefer keeping it this 
> way. […]
return l1ctl_tx_gprs_ul_block_req(ms,
                                   lp->pdch_data_req.fn,
                                   lp->pdch_data_req.ts_nr,
                                   lp->pdch_data_req.data,
                                   lp->pdch_data_req.data_len);



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31572
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I38e9a686f8edc3fe55f961d75e68602c33bbbaaf
Gerrit-Change-Number: 31572
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Mar 2023 16:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to