Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32734 )
Change subject: paging: do not confirm PAGING COMMAND messages ...................................................................... Patch Set 12: Code-Review-1 (4 comments) Patchset: PS12: CR-1 due to wrong pointer arithmetic. File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/32734/comment/66cbc845_6389d526 PS12, Line 670: imsi This array can be moved to the respective scope of use now. https://gerrit.osmocom.org/c/osmo-bts/+/32734/comment/98ce7c0f_e7b55591 PS12, Line 680: struct gsm48_imm_ass *gsm48_imm_ass `const` please https://gerrit.osmocom.org/c/osmo-bts/+/32734/comment/3f476a31_70c3394f PS12, Line 683: (struct gsm48_imm_ass *)data_req->data + 3 This looks wrong to me. Without braces the `+ 3` is not "skip three bytes", but actually "skip three sizeof(struct gsm48_imm_ass)". gdb confirms this: ``` (gdb) p (struct gsm48_imm_ass *)0x00 $6 = (struct gsm48_imm_ass *) 0x0 (gdb) p (struct gsm48_imm_ass *)0x00 + 3 $7 = (struct gsm48_imm_ass *) 0x24 (gdb) p/x sizeof(struct gsm48_imm_ass) * 3 $8 = 0x24 ``` It should be: ``` gsm48_imm_ass = (struct gsm48_imm_ass *)&data_req->data[3]; ``` or ``` gsm48_imm_ass = (struct gsm48_imm_ass *)(data_req->data + 3); ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8b8264d28b1b1deb08774cdba58dd4c6dafe115d Gerrit-Change-Number: 32734 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jun 2023 09:48:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
