Attention is currently required from: fixeria.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/32734 )

Change subject: paging: do not confirm PAGING COMMAND messages
......................................................................


Patch Set 14:

(3 comments)

File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32734/comment/a0cd5984_759e75b1
PS12, Line 670: imsi
> This array can be moved to the respective scope of use now.
I have put that in a follow up patch


https://gerrit.osmocom.org/c/osmo-bts/+/32734/comment/546c9222_36cddc9a
PS12, Line 680: struct gsm48_imm_ass *gsm48_imm_ass
> `const` please
Done


https://gerrit.osmocom.org/c/osmo-bts/+/32734/comment/d8e9db8e_d4d59073
PS12, Line 683: (struct gsm48_imm_ass *)data_req->data + 3
> This looks wrong to me. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32734
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8b8264d28b1b1deb08774cdba58dd4c6dafe115d
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 14
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jun 2023 10:26:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to